fix: skip decommission status for unsupported topology - #199
Open
ccccpj wants to merge 1 commit into
Open
Conversation
cxymds
marked this pull request as ready for review
August 7, 2026 02:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the Pool Decommission page so it determines topology support from the pools overview before requesting decommission status.
The page previously started
/pools/list,/rebalance/status, and/decommission/statustogether. In a single-pool deployment, the backend intentionally does not provide decommission status and returns 501, so the otherwise valid unsupported topology was rendered as Load Failed.This change:
/decommission/statuswhensupportStateisunsupported;Type of Change
Testing
pnpm install --frozen-lockfile pnpm type-check pnpm lint pnpm test:run pnpm prettier --check 'app/(dashboard)/pool-decommission/page.tsx' lib/pool-decommission-load.ts tests/lib/pool-decommission-load.test.ts tests/lib/pool-operations-safety.test.js git diff --checkpnpm test:run: 392 tests passed.pnpm format:checkremains blocked by the unchanged upstream filecomponents/object/tiff-viewer.tsx; every file in this PR passes Prettier.Checklist
Related Issues
Fixes rustfs/rustfs#5773
Screenshots (if applicable)
The after captures use a deterministic local mock with one active 1 TiB pool. The mock returns 501 for
/decommission/status, matching the reported backend behavior.Before
After
Desktop
Mobile
Additional Notes
This PR does not change the RustFS backend's 501 contract for unsupported single-pool decommission status. Supported multi-pool status failures continue to render an error and keep interactions locked.