test(cli): cover object remove purge help contract#94
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a focused help-contract test for the noun-first
rc object removecommand. The recentrm --purgework changed the shared remove argument surface, but the help-contract suite only covered the legacyrc rmentrypoint and did not verify that the noun-first alias exposed the same option set.Problem
Users can reach object deletion through both
rc rmandrc object remove. Becauseobject removereusesRmArgs, option changes such as--purgeshould remain discoverable through both entrypoints. Without a contract test on the noun-first command, a future clap wiring or command-group change could silently drop or alter that help surface while the existingrmhelp test still passed.Fix
The test suite now asserts the
rc object remove --helpusage line, the inherited delete options, and a representative example. The new case includes--purge, which ties the test directly to the recent remove-command change while keeping the scope limited to help-contract coverage.Validation
I could not run
make pre-commitbecause this repository does not contain aMakefileor apre-committarget. I ran the equivalent required checks from the repository instructions instead:cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace