Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds focused regression coverage for two untested CORS paths introduced by the recent bucket CORS feature work.
The first gap was XML normalization when optional header fields are present but blank. The JSON parser path already had coverage for trimming empty
allowedHeadersandexposeHeaders, but the XML path did not. This matters becauserc bucket cors setaccepts both JSON and XML inputs, and users can reasonably provide empty XML elements from exported or hand-edited configs.The second gap was the deprecated top-level
rc cors getalias. The newer nestedrc bucket cors getpath already had parser coverage, andrc cors removewas covered, but the top-levelgetalias was not. This PR verifies that the compatibility path still resolves to the list command and preserves the bucket argument.Validation
I attempted to run
make pre-commitas requested by the automation, but this repository currently has noMakefileand nopre-committarget. I therefore ran the documented repository checks directly:cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspaceAll of the above passed.