Add initial MinGW support by Jookia · Pull Request #60 · rust9x/rust

Jookia · 2026-06-27T00:38:18Z

Here's the initial MinGW support. It is missing:

Unicows support (if this needs to be added to the compiler)
Fixed backtraces (requires work in the backtrace crate)
Testing for the x86_64 target

I will write up some instructions when it's a little more mature, hopefully that could be added to the wiki. I'm happy to write instructions for anyone for the purposes of testing and review.

cher-nov

A note in the commit comment explaining why GetFileSize() is more backward-compatible than GetFileSizeEx() would be also great.

Jookia · 2026-06-28T05:10:57Z

I've realized there's no i686-rust9x-windows-msvc target. Would it be okay to drop the i686-rust9x-windows-gnu target? That would leave only two new targets: i586-rust9x-windows-gnu and x86_64-rust9x-windows-gnu.

Edit: I was wrong, I missed it. Previous Jookia was right.

This commit introduces the following targets: - x86_64-rust9x-windows-gnu: 64-bit Windows XP onwards - i686-rust9x-windows-gnu: i686 Windows NT4/98 onwards - i586-rust9x-windows-gnu: i586 Windows NT4/98 onwards The MinGW target has a higher minimum OS version for a two reasons: 1. MSVCRT is expected to be shipped with the operating system 2. pthreads requires NT4 functions

An earlier Rust9x patch (see Fixes:) changes the function signature for hashmap_random_keys. This breaks cross-compiling on Linux. Modify the Linux code to use the new signature as a fix. Fixes: cd6c320

The Rust bootstrap code currently tries to build the rtstartup objects using a stage0 compiler because it's a bit more convenient. The stage0 compiler doesn't know about rust9x targets so instruct it to use a compiler we've built instead.

Windows Vista onwards implements APIs to handle initializing values once. Use a double-lock on Rust9x for backwards compatibility.

seritools

looking good! one small nit, otherwise good to go!

seritools · 2026-06-28T14:49:50Z

+            let pending = self.pending.load(Acquire);
+            if pending == false {


nit: could store initialized instead, preventing the inverted logic here (and have the initial state be zero instead of 1)

I kind of wanted to match the the logic from the other code but yeah I can update this.

ah i see, that makes sense -- std Once also seems to agree:

rust/library/std/src/sys/sync/once/futex.rs

Lines 19 to 22 in 25a5ea7

/// Initialization has completed and all future calls should finish immediately.

/// By choosing this state as the all-zero state the `is_completed` check can be

/// a bit faster on some platforms.

const COMPLETE: Primitive = 0;

am convinced, can stay as is ^^

also, if !pending would be better I guess?

It's a somewhat stylistic choice but I wanted to match the other functions pending == c::FALSE.

If it really matters I can do a PR for it.

Jookia · 2026-06-28T14:57:45Z

Alright! I'll give it a day or two to sit and fix the nit and anything else you think of. I'll open some other PRs in the mean time. If @cher-nov has any other input that would be good. :)

seritools · 2026-06-28T15:01:43Z

+            let pending = self.pending.load(Acquire);
+            if pending == false {


ah i see, that makes sense -- std Once also seems to agree:

rust/library/std/src/sys/sync/once/futex.rs

Lines 19 to 22 in 25a5ea7

/// Initialization has completed and all future calls should finish immediately.

/// By choosing this state as the all-zero state the `is_completed` check can be

/// a bit faster on some platforms.

const COMPLETE: Primitive = 0;

am convinced, can stay as is ^^

Jookia · 2026-06-28T15:04:00Z

Yay!

Jookia mentioned this pull request Jun 27, 2026

Add support for mingw targets #24

Open

cher-nov suggested changes Jun 27, 2026

View reviewed changes

Comment thread library/std/src/sys/fs/windows.rs Outdated

seritools reviewed Jun 27, 2026

View reviewed changes

Comment thread library/std/src/sys/random/linux.rs

Comment thread compiler/rustc_target/src/spec/base/windows_gnu.rs Outdated

Comment thread library/std/src/sys/fs/windows.rs Outdated

Comment thread src/bootstrap/src/core/build_steps/compile.rs

seritools mentioned this pull request Jun 28, 2026

Investigate issues with thread locals #12

Open

seritools reviewed Jun 28, 2026

View reviewed changes

Comment thread src/bootstrap/src/core/sanity.rs

Jookia added 3 commits June 28, 2026 23:14

Fix hashmap_random_keys on Linux

bf9dddc

An earlier Rust9x patch (see Fixes:) changes the function signature for hashmap_random_keys. This breaks cross-compiling on Linux. Modify the Linux code to use the new signature as a fix. Fixes: cd6c320

seritools mentioned this pull request Jun 28, 2026

Added something useful (CI, docs) #57

Open

Don't use InitOnce* APIs for TLS keys on Rust9x

45814b4

Windows Vista onwards implements APIs to handle initializing values once. Use a double-lock on Rust9x for backwards compatibility.

Jookia force-pushed the jookia_mingw branch from 52a1458 to 45814b4 Compare June 28, 2026 14:35

seritools approved these changes Jun 28, 2026

View reviewed changes

seritools merged commit be4391a into rust9x:rust9x Jun 28, 2026

Jookia deleted the jookia_mingw branch June 28, 2026 15:23

		let pending = self.pending.load(Acquire);
		if pending == false {

	/// Initialization has completed and all future calls should finish immediately.
	/// By choosing this state as the all-zero state the `is_completed` check can be
	/// a bit faster on some platforms.
	const COMPLETE: Primitive = 0;

Uh oh!

Conversation

Jookia commented Jun 27, 2026

Uh oh!

cher-nov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jookia commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

seritools left a comment

Choose a reason for hiding this comment

Uh oh!

seritools Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

Jookia Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

seritools Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

cher-nov Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

Jookia Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Jookia commented Jun 28, 2026

Uh oh!

seritools Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

Jookia commented Jun 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cher-nov left a comment •

edited

Loading

Jookia commented Jun 28, 2026 •

edited

Loading