Only create a URL when opening docs with URI fragments - #5036
Merged
Conversation
2 tasks
ChrisDenton
force-pushed
the
shell-execute
branch
from
August 27, 2026 17:36
373fcc0 to
246f518
Compare
rami3l
approved these changes
Aug 27, 2026
ShellExecuteW does not handle urls very well so we try to avoid it as much as possible
ChrisDenton
force-pushed
the
shell-execute
branch
from
August 27, 2026 17:50
246f518 to
96f190b
Compare
ChrisDenton
enabled auto-merge
August 27, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShellExecuteWdoes not handle urls very well so we try to avoid it as much as possible.This is only a partial workaround for #5035 but it does allow new users basic access to the docs. I can implement a fuller fix but I'd want more time to test and evaluate the trade-offs so I think this is good to go in the meantime and I think this might be a good idea even if we do have a full fix (no point making a url if we don't have to).