ci tests rustfmt, but rustfmt doesn't test ci

[AsthaMishra]

Mismatch at ci/src/common.rs:12:
     })
 }
 
-pub                                fn run_command_with_env<I, S>(
+pub fn run_command_with_env<I, S>(
     bin: &str,
     args: I,
     current_dir: &str,

@ytmimi your suggestion works. Confirmed: before adding "ci" to external_crates, self_tests passed even with pub fn run_command_with_env<I, S>( in ci/src/common.rs. After the change it fails with a mismatch on that line.

fixes : #7039

[ytmimi]

before adding "ci" to external_crates, self_tests passed even with pub fn run_command_with_env<I, S>( in ci/src/common.rs. After the change it fails with a mismatch on that line.

What does this mean? CI is green. Are you saying that there's a formatting error that we're not catching?

[ytmimi]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[AsthaMishra]

What does this mean?

it works after your suggestion

Are you saying that there's a formatting error that we're not catching?

no

[matthewhughes934]

CI is green. Are you saying that there's a formatting error that we're not catching?

Not directly related to this change (i.e. the issue exists on main), but I see a diff:

/rustfmt$ cargo build
/rustfmt$ cd ./check_diff
/rustfmt/check_diff$ RUSTFMT=../target/debug/rustfmt cargo fmt --check
Diff in /home/mjh/src/rustfmt/check_diff/tests/check_diff.rs:1:
 use check_diff::{
-    CheckDiffError, DiffChecker, CodeFormatter, FormatCodeError, Repository,
-    RustFmtFileFinder, check_diff,
+    CheckDiffError, CodeFormatter, DiffChecker, FormatCodeError, Repository, RustFmtFileFinder,
+    check_diff,
 };
 use std::fs::File;
 use tempfile::Builder;

[AsthaMishra]

@matthewhughes934 because we are only checking files of src folder in external_crate

rustfmt/src/test/mod.rs

Lines 489 to 506 in 1191d91

	let external_crates = vec!["check_diff", "config_proc_macro"];
	for external_crate in external_crates {
	let mut path = PathBuf::from(external_crate);
	path.push("src");
	let directory = fs::read_dir(&path).unwrap();
	let search_files = directory.filter_map(|file| {
	file.ok().and_then(|f| {
	let name = f.file_name();
	if matches!(name.as_os_str().to_str(), Some("main.rs" | "lib.rs")) {
	Some(f.path())
	} else {
	None
	}
	})
	});
	for file in search_files {
	files.push(file);
	}

This fixes the external_crate/tests/ directory:

let mut tests_files = get_test_files(&PathBuf::from(external_crate).join("tests"), false);
files.append(&mut tests_files);

[AsthaMishra]

@rustbot ready

[ytmimi]

@AsthaMishra has the test directory issue been fixed? We should probably just take care of that in this PR too.

[AsthaMishra]

@ytmimi yes, pushed

[ytmimi]

I think it would be fine for us to recursively look for .rs files within the "tests" directory of check_diff, config_proc_macro, and ci since those test files don't have a special structure to them like tests/source and tests/target do for the rustfmt test suite.

View changes since the review

[AsthaMishra]

pushed