break the dependency from rustc_target -> rustc_fs_util - #160379
Closed
jyn514 wants to merge 1 commit into
Closed
Conversation
fs_util is now first needed by `rustc_session`, so it's not needed before compiling `rustc_hir`.
Collaborator
|
These commits modify compiler targets. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Contributor
|
I'd rather not make this change, rustc_fs_util is compiled way, way before any other rustc crates using it so it's not going to matter for compiling in parallel. I think it's more valuable to have all of rustc's path handling logic being in one place. |
Member
Author
|
makes sense 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs_util is now first needed by
rustc_session, so it's not needed before compilingrustc_hir. i haven't yet collected before/after timings, i can do so if you like.inspired by #160336.
before:

after:

disclaimer: this PR was LLM generated. i told it to look at #160336 and find similar improvements, and it wrote the code. originally it also tried to break
rustc_feature -> rustc_hirandrustc_metadata -> rustc_incremental, but it turns out i was on an old branch and those had already been split up on main.r? @jackh726 (not the PR i said you would be reviewing, oops, but still quite small)
@rustbot label llm-assisted