Split SpannedTypeVisitor into its own crate, rustc_ty_walk

[joshtriplett]

rustc_privacy pulls in all of rustc_ty_utils, but only wants SpannedTypeVisitor and walk_types. Move those to a small rustc_ty_walk crate.

This allows rustc_privacy to start building much sooner.

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[rustbot]

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 75 candidates
• Random selection from 18 candidates

[mejrs]

You need to bless bootstrap, see https://github.com/rust-lang/rust/blob/main/src/bootstrap/README.md#testing

[fee1-dead]

Is there a way to just move these to be defined to rustc_privacy directly?

View changes since the review

[joshtriplett]

@fee1-dead They're used by both rustc_ty_utils and rustc_privacy, so they need to be in a common crate available to both. I don't want to make rustc_ty_utils depend on rustc_privacy, and I don't think they logically fit in rustc_privacy.

[mejrs]

Logically it probably fits in rustc_middle - not that I want to move stuff there.

[joshtriplett]

@rustbot ready

[mejrs]

I think we should consider splitting up rustc_ty_utils (perhaps poorly named if it's just providing queries now?) further:

crate A: Queries that need rustc_trait_selection
crate B: Queries that only need rustc_middle (or perhaps rustc_infer - haven't thought about what the best split is here)
crate C: What this pr calls rustc_ty_walk - the actual util stuff shared between A and B and other crates. Maybe there's also stuff currently defined in rustc_middle that could be moved here.