Specialize advance_by method of Fuse - #160342
Open
a1phyr wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
joboet
approved these changes
Aug 1, 2026
Member
|
Thanks! Let's just wait for CI to come back green... @bors delegate+ |
Contributor
|
Since the intent of this PR is optimization of a frequently used function, would it be a good idea to do a perf run on it, to ensure that the optimization actually helps and that this isn't somehow accidentally regressing? It'll probably be a wash because I don't actually think that the compiler uses |
Contributor
Author
|
Yes, I don't think that it would change anything for the compiler. @bors r=joboet |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 1, 2026
Specialize `advance_by` method of `Fuse` `advance_by` is used a lot internally so it seems important to specialize it.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 1, 2026
Specialize `advance_by` method of `Fuse` `advance_by` is used a lot internally so it seems important to specialize it.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 2, 2026
Rollup of 6 pull requests Successful merges: - #159844 (Subtree cg_gcc sync (2026-07-24)) - #156527 (Move `std::io` tests to `alloctests` & add prelude) - #159525 (Stabilize passing 128-bit integers via vector registers with `asm!` on x86) - #160342 (Specialize `advance_by` method of `Fuse`) - #106643 (Allow only implementing `Read::read_buf`) - #159729 (allocations are allowed to grow (but not shrink))
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 2, 2026
Specialize `advance_by` method of `Fuse` `advance_by` is used a lot internally so it seems important to specialize it.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 2, 2026
Rollup of 6 pull requests Successful merges: - #156527 (Move `std::io` tests to `alloctests` & add prelude) - #159525 (Stabilize passing 128-bit integers via vector registers with `asm!` on x86) - #160342 (Specialize `advance_by` method of `Fuse`) - #106643 (Allow only implementing `Read::read_buf`) - #159729 (allocations are allowed to grow (but not shrink)) - #159881 (fix: Do not stop `visible_parent_map` breadth-first search reaching children of `#[doc(hidden)]` modules)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 2, 2026
Specialize `advance_by` method of `Fuse` `advance_by` is used a lot internally so it seems important to specialize it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
advance_byis used a lot internally so it seems important to specialize it.