Bump thorin-dwp (0.10), gimli (0.33), and object (0.38.1) - #160318
Open
Zalathar wants to merge 1 commit into
Open
Bump thorin-dwp (0.10), gimli (0.33), and object (0.38.1)#160318Zalathar wants to merge 1 commit into
Zalathar wants to merge 1 commit into
Conversation
Collaborator
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. cc @davidtwco, @BoxyUwU These commits modify the If this was unintentional then you should revert the changes before this PR is merged. The run-make-support library was changed cc @jieyouxu |
rustbot
added
A-LLVM
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
the
T-compiler
Member
Author
|
cc @mejrs who reminded me of this. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Ah, looks like bumping the deps of |
Zalathar
commented
Aug 1, 2026
Comment on lines
+83
to
+87
| let entry_depth = entry.depth; | ||
| let Some(child_entry) = cursor.next_dfs().unwrap() else { | ||
| panic!("Missing child of DW_TAG_variant"); | ||
| }; | ||
| assert_eq!(child_entry.depth, entry_depth + 1); |
Member
Author
There was a problem hiding this comment.
Changed
read::EntriesCursor::next_dfsto no longer return the depth delta. Useread::DebuggingInformationEntry::depthinstead.
Member
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 2, 2026
Bump thorin-dwp (0.10), gimli (0.33), and object (0.38.1)
Originally, the hope was that this would reduce duplication of `object` within the compiler.
In practice, it turns out that this merely bumps the object major-version-set from {0.36, 0.37} to {0.37, 0.38}.
(The holdout for object@0.37 is `ar_archive_writer`, which does have a newer release available. But that would end up pulling in object@0.39 instead.)
There is still an object@0.36 entry in Cargo.lock, but that comes via `ui_test` which is a dev-dependency for clippy and miri.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 2, 2026
Bump thorin-dwp (0.10), gimli (0.33), and object (0.38.1)
Originally, the hope was that this would reduce duplication of `object` within the compiler.
In practice, it turns out that this merely bumps the object major-version-set from {0.36, 0.37} to {0.37, 0.38}.
(The holdout for object@0.37 is `ar_archive_writer`, which does have a newer release available. But that would end up pulling in object@0.39 instead.)
There is still an object@0.36 entry in Cargo.lock, but that comes via `ui_test` which is a dev-dependency for clippy and miri.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 2, 2026
…uwer Rollup of 5 pull requests Successful merges: - #159195 (Drop elaboration: Only create a reset block if there are flags to reset.) - #160318 (Bump thorin-dwp (0.10), gimli (0.33), and object (0.38.1)) - #159756 (bootstrap: Move some shared source files into a new `shim_utils` crate) - #160385 (Assign ownership for Renovate configuration file) - #160397 (Box::new: fix safety comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, the hope was that this would reduce duplication of
objectwithin the compiler.In practice, it turns out that this merely bumps the object major-version-set from {0.36, 0.37} to {0.37, 0.38}.
(The holdout for object@0.37 is
ar_archive_writer, which does have a newer release available. But that would end up pulling in object@0.39 instead.)There is still an object@0.36 entry in Cargo.lock, but that comes via
ui_testwhich is a dev-dependency for clippy and miri.