Improve E0603 suggestions for private grouped imports

[raushan728]

View all comments

After PR #156244 removed broken suggestions for nested imports, E0603 was left without any suggestion. This restores helpful suggestions for grouped use statements.

For use crate::two::{One, Two} with a private One:

  + use crate::one::One;
  ~ use crate::two::Two;

Single item groups get a direct replacement. Braces are removed when one item remains. Re-export chains are handled.

Fixes #157453.

r? @petrochenkov

[rustbot]

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 73 candidates
• Random selection from 18 candidates

[petrochenkov]

I reviewed everything except the compiler/rustc_resolve/src/error_helper.rs part, which is full of byte pos arithmetics and other wonders.

r? @fee1-dead please review, since you wanted this.

[rustbot]

fee1-dead is not on the review rotation at the moment.
They may take a while to respond.

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[raushan728]

@rustbot ready

[fee1-dead]

A lot of these string fiddling is still not sitting well with me. It shouldn't be too hard to use the string search functions Rust already have to do some of these. Please use them, as we want compiler code to be readable.

View changes since this review

[raushan728]

A lot of these string fiddling is still not sitting well with me. It shouldn't be too hard to use the string search functions Rust already have to do some of these. Please use them, as we want compiler code to be readable.

I've cleaned this up to rely on the standard string search APIs (find, starts_with, trim_*, etc.). I think its better If anything you'd like to change?

[fee1-dead]

unable to review this. previous versions seem to be LLM generated. Current revision is better but still relies heavily on index computations when that can be avoided

View changes since this review

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[raushan728]

relies heavily on index computations when that can be avoided

I removed the manual span/index computations and simplifying the data flow. Could you take a another look? thanks!

[fee1-dead]

This is much better, but I fear it would not be a great use of my time reviewing this. I believe this has more value to be done by someone who is genuinely learning about the codebase rather than someone using an LLM.

View changes since this review

[raushan728]

Sorry for the previous revisions. I've cleaned up the code and addressed the earlier feedback where I could. I think it's in a much better state now and hopefully easier to review.