rustdoc: Avoid ICE on unevaluated type const projections in array lengths#158171
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @camelid rustbot has assigned @camelid. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
lapla-cogito
force-pushed
the
issue_158155
branch
3 times, most recently
from
c256212 to
7a6277d
Compare
camelid
reviewed
Jun 22, 2026
Member
There was a problem hiding this comment.
Could you move this test to the rustdoc-html directory, and then you can add @has checks to make sure the HTML output is actually correct? Currently this test just makes sure rustdoc doesn't crash, but not that the output looks right. So basically for both your new test case and the existing one in the file, add a check that the type renders correctly as [(); <T as Tr>::SIZE].
You can see examples of how @has checks look in the other tests in rustdoc-html, or the docs for it here. Feel free to ask me here or on Zulip if you need help!
Contributor
Author
There was a problem hiding this comment.
Thanks, updated the test. Additionally, when actually adding the @has check, I found that the previous fix alone result in the HTML displaying [(); const SIZE: usize;]. This issue occurred because print_inlined_const() was displaying the definition side for assoc const projections without bodies, so I've included a corresponding fix for this as well.
camelid
added
S-waiting-on-author
lapla-cogito
force-pushed
the
issue_158155
branch
from
7a6277d to
c503572
Compare
rustbot
added
the
T-rustdoc-frontend
lapla-cogito
force-pushed
the
issue_158155
branch
from
0b9758a to
a616db3
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
camelid
approved these changes
Jun 22, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 22, 2026
…uwer Rollup of 8 pull requests Successful merges: - #158242 (Fix linking for wasm with crate metadata included) - #157978 (Avoid `&raw` recovery ICE after trailing comma) - #158119 (Refactor `proc_macro_decls_static`) - #158171 (rustdoc: Avoid ICE on unevaluated `type const` projections in array lengths) - #158172 (update `asm_experimental_reg` comments) - #158230 (Include `Item::stability` info in rustdoc JSON.) - #158258 (Use an unexpanded span for actually written down opt out params) - #158262 (Change compiler leads in triagebot.toml)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 22, 2026
…uwer Rollup of 8 pull requests Successful merges: - #158242 (Fix linking for wasm with crate metadata included) - #157978 (Avoid `&raw` recovery ICE after trailing comma) - #158119 (Refactor `proc_macro_decls_static`) - #158171 (rustdoc: Avoid ICE on unevaluated `type const` projections in array lengths) - #158172 (update `asm_experimental_reg` comments) - #158230 (Include `Item::stability` info in rustdoc JSON.) - #158258 (Use an unexpanded span for actually written down opt out params) - #158262 (Change compiler leads in triagebot.toml)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 22, 2026
…uwer Rollup of 8 pull requests Successful merges: - #158242 (Fix linking for wasm with crate metadata included) - #157978 (Avoid `&raw` recovery ICE after trailing comma) - #158119 (Refactor `proc_macro_decls_static`) - #158171 (rustdoc: Avoid ICE on unevaluated `type const` projections in array lengths) - #158172 (update `asm_experimental_reg` comments) - #158230 (Include `Item::stability` info in rustdoc JSON.) - #158258 (Use an unexpanded span for actually written down opt out params) - #158262 (Change compiler leads in triagebot.toml)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 22, 2026
…uwer Rollup of 8 pull requests Successful merges: - #158242 (Fix linking for wasm with crate metadata included) - #157978 (Avoid `&raw` recovery ICE after trailing comma) - #158119 (Refactor `proc_macro_decls_static`) - #158171 (rustdoc: Avoid ICE on unevaluated `type const` projections in array lengths) - #158172 (update `asm_experimental_reg` comments) - #158230 (Include `Item::stability` info in rustdoc JSON.) - #158258 (Use an unexpanded span for actually written down opt out params) - #158262 (Change compiler leads in triagebot.toml)
rust-timer
added a commit
that referenced
this pull request
Jun 22, 2026
Rollup merge of #158171 - lapla-cogito:issue_158155, r=camelid rustdoc: Avoid ICE on unevaluated `type const` projections in array lengths `clean_middle_ty` used `normalize_erasing_regions` when rendering array lengths, which panics on unevaluatable associated const projections such as `<T as Trait>::ASSOC` under mGCA. Fixes #158155
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 1, 2026
…camelid rustdoc: Show use-site paths for unevaluated const array lengths After rust-lang#158171, I noticed a few additional issues with the rendering of consts in rustdoc. This PR fixes them. When rendering array lengths, avoid inlining the full definition of unevaluated constants via `print_inlined_const`. Instead, fall back to `Const::to_string()` for use-site rendering, matching the behavior already used for projections without bodies. r? camelid
rust-timer
added a commit
that referenced
this pull request
Jul 2, 2026
Rollup merge of #158334 - lapla-cogito:rustdoc_typeconst, r=camelid rustdoc: Show use-site paths for unevaluated const array lengths After #158171, I noticed a few additional issues with the rendering of consts in rustdoc. This PR fixes them. When rendering array lengths, avoid inlining the full definition of unevaluated constants via `print_inlined_const`. Instead, fall back to `Const::to_string()` for use-site rendering, matching the behavior already used for projections without bodies. r? camelid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean_middle_tyusednormalize_erasing_regionswhen rendering array lengths, which panics on unevaluatable associated const projections such as<T as Trait>::ASSOCunder mGCA.Fixes #158155