Rollup of 3 pull requests#158015
Merged
Merged
Conversation
specifically `needs-llvm-components`
Improve `declare_features!` macro error
I got mildly annoyed when I went to add a new feature, and the fix for this is relatively simple.
Current error:
```
error[E0425]: cannot find value `better_rust` in module `sym`
--> compiler\rustc_feature\src\unstable.rs:240:16
|
157 | name: sym::$feature,
| -------- due to this macro variable
...
240 | (internal, better_rust, "2.0.0", None),
| ^^^^^^^^^^^ not found in `sym`
For more information about this error, try `rustc --explain E0425`
```
Previous error:
```
error[E0425]: cannot find value `better_rust` in module `sym`
--> compiler\rustc_feature\src\unstable.rs:240:16
|
157 | name: sym::$feature,
| -------- due to this macro variable
...
240 | (internal, better_rust, "2.0.0", None),
| ^^^^^^^^^^^ not found in `sym`
error[E0531]: cannot find unit struct, unit variant or constant `better_rust` in module `sym`
--> compiler\rustc_feature\src\unstable.rs:240:16
|
157 | name: sym::$feature,
| -------- due to this macro variable
...
240 | (internal, better_rust, "2.0.0", None),
| ^^^^^^^^^^^ not found in `sym`
Some errors have detailed explanations: E0425, E0531.
```
…jieyouxu tidy: revisions inherit global directives specifically `needs-llvm-components` Based on this function, directives apply to a revision also when the directive is defined "globally". https://github.com/rust-lang/rust/blob/89a99936d9e76a50e8df622e7242190841fd871b/src/tools/compiletest/src/directives/line.rs#L100-L102 But `tidy` did not take that into account. I'm not sure how to test this. r? jieyouxu
…mver, r=marcoieni renovate: Pin GitHub Action digests to SemVer Switches the `helpers:pinGitHubActionDigests` preset to `helpers:pinGitHubActionDigestsToSemver`. This resolves floating tags (e.g. `v4`) to a full SemVer version behind the digest and tracks SemVer releases instead of floating tags. r? @marcoieni
rustbot
added
A-tidy
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
removed
the
S-waiting-on-bors
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 98594f404e In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 98594f4 (parent) -> 1162ebd (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1162ebd81da49955aa94ef240cf7bb0bafad3f6a --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (1162ebd): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (secondary 3.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 523.739s -> 521.352s (-0.46%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
declare_features!macro error #157931 (Improvedeclare_features!macro error)r? @ghost
Create a similar rollup