Skip to content

Stabilize strip_circumfix#158012

Open
yotamofek wants to merge 1 commit into
rust-lang:mainfrom
yotamofek:pr/stabilize-strip-circumfix
Open

Stabilize strip_circumfix#158012
yotamofek wants to merge 1 commit into
rust-lang:mainfrom
yotamofek:pr/stabilize-strip-circumfix

Conversation

@yotamofek

@yotamofek yotamofek commented Jun 17, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Tracking issue: #147946

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 17, 2026
@rustbot

rustbot commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 11 candidates
  • Random selection from 6 candidates

@joboet

joboet commented Jun 17, 2026

Copy link
Copy Markdown
Member

r? libs-api
@rustbot label +needs-fcp

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 17, 2026
@rustbot rustbot assigned the8472 and unassigned joboet Jun 17, 2026
@rustbot rustbot added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Jun 17, 2026
@Urgau

Urgau commented Jun 17, 2026

Copy link
Copy Markdown
Member

@joboet It already had an FCP in #147946 (comment).

@yotamofek

yotamofek commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@joboet the tracking issue already went through an FCP. Isn't that enough? (Sorry if I'm being ignorant, first time going through the stabilization process)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@joboet joboet assigned joboet and unassigned the8472 Jun 17, 2026
@yotamofek yotamofek force-pushed the pr/stabilize-strip-circumfix branch from a130f53 to fd30268 Compare June 17, 2026 09:04
@joboet

joboet commented Jun 17, 2026

Copy link
Copy Markdown
Member

Oh, whoops, I didn't check...

In that case, r=me with CI passing.

@yotamofek

yotamofek commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Thanks!
I guess I can't yet remove the feature flags from where it's actually being used inside the compiler?
(that's what I thought but the dev guide says differently)

@joboet

joboet commented Jun 17, 2026

Copy link
Copy Markdown
Member

Note that you need to keep around the feature gates, but only in the bootstrap compiler (since the feature is still unstable in the beta-std). You can use #![cfg_attr(bootstrap, feature(strip_circumfix))] for that, it'll get removed in the next bootstrap-toolchain bump.

@yotamofek yotamofek force-pushed the pr/stabilize-strip-circumfix branch from fd30268 to 439746b Compare June 17, 2026 09:08
@yotamofek

yotamofek commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Got it, thanks!
rust-lang/std-dev-guide#77

@yotamofek

yotamofek commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=joboet

@rust-bors

rust-bors Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

📋 This PR cannot be approved because it currently has the following label: needs-fcp.

@yotamofek

yotamofek commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot label -needs-fcp

@rustbot rustbot removed the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Jun 17, 2026
@yotamofek

yotamofek commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=joboet

@rust-bors

rust-bors Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 439746b has been approved by joboet

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 17, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158012 - yotamofek:pr/stabilize-strip-circu…
941a78f 
…mfix, r=joboet

Stabilize `strip_circumfix`

Tracking issue: rust-lang#147946
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboet joboet

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yotamofek @rustbot @joboet @Urgau @rust-log-analyzer @the8472