Update comments and add tests for -Zrandomize-layout for some guaranteed ZSTs#157905
Draft
zachs18 wants to merge 2 commits into
Draft
Update comments and add tests for -Zrandomize-layout for some guaranteed ZSTs#157905zachs18 wants to merge 2 commits into
-Zrandomize-layout for some guaranteed ZSTs#157905zachs18 wants to merge 2 commits into
Conversation
rustbot
added
S-waiting-on-author
zachs18
changed the title
-Zrandomize-layout for some guaranteed ZSTs
Contributor
|
@rustbot label +A-ZST "+-Zrandomize-layout" |
rustbot
added
-Zrandomize-layout
Contributor
|
Would it make sense to add tests for this? |
zachs18
force-pushed
the
randomize-layout-zst-note
branch
from
6c36967 to
63e9672
Compare
…d ZST struct/enums. Also add tests for the guaranteed types.
zachs18
force-pushed
the
randomize-layout-zst-note
branch
from
63e9672 to
57b4ab5
Compare
zachs18
changed the title
-Zrandomize-layout for some guaranteed ZSTs-Zrandomize-layout for some guaranteed ZSTs
zachs18
force-pushed
the
randomize-layout-zst-note
branch
from
57b4ab5 to
78ea28b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-lang/reference#2262 . T-lang wants to make some additional guarantees about zero-sized
repr(Rust)structs and enums, that changes to-Zrandomize-layoutcould theoretically break in the future. This PR adds comments to-Zrandomize-layout's implementation and tests totests/ui/layout/randomize.rsto prevent breaking those guarantees.First commit is the guarantees that T-lang is currently FCP'ing in rust-lang/reference#2262 .
Second commit is an additional guarantee (that zero-variant repr(Rust) enums are ZSTs) that's at rust-lang/reference#2293