Skip to content

library: std: fs: skip tests on Hermit - #153294

Open
Gelbpunkt wants to merge 1 commit into
rust-lang:mainfrom
Gelbpunkt:skip-fs-tests-hermit
Open

library: std: fs: skip tests on Hermit#153294
Gelbpunkt wants to merge 1 commit into
rust-lang:mainfrom
Gelbpunkt:skip-fs-tests-hermit

Conversation

@Gelbpunkt

@Gelbpunkt Gelbpunkt commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

The tests make use of symlinks, which are not currently supported on Hermit.

@Gelbpunkt
library: std: fs: skip tests on Hermit
a3bf4f8 
The tests make use of symlinks, which are not currently supported on
Hermit.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 2, 2026
@rustbot

rustbot commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, joboet

tgross35
tgross35 reviewed Mar 4, 2026
View reviewed changes
Comment thread library/std/src/fs.rs
Comment on lines 32 to 43
#[cfg(all(
test,
not(any(
target_os = "emscripten",
target_os = "wasi",
target_env = "sgx",
target_os = "xous",
target_os = "trusty",
target_os = "hermit",
))
))]
mod tests;

@tgross35 tgross35 Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a comment about why they're skipped

@tgross35

tgross35 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

If symlinks are a problem but everything else works, could only the relevant tests be skipped? Or moved into an inline module to make that easier.

Cc target maintainers @stlankes @mkroening

@Gelbpunkt

Gelbpunkt commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Or moved into an inline module to make that easier.

That sounds reasonable. I'll update the PR to do that.

@joboet

joboet commented Mar 12, 2026

Copy link
Copy Markdown
Member

Yeah, I'd prefer that.

@rustbot author
until then.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@rustbot

rustbot commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rust-bors

rust-bors Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #160725) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@joboet joboet

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gelbpunkt @rustbot @tgross35 @joboet