Skip to content

remove #[rustc_intrinsic_must_be_overridde]#137489

Merged
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:no-more-rustc_intrinsic_must_be_overridden
Feb 25, 2025
Merged

remove #[rustc_intrinsic_must_be_overridde]#137489
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:no-more-rustc_intrinsic_must_be_overridden

Conversation

@RalfJung

@RalfJung RalfJung commented Feb 23, 2025

Copy link
Copy Markdown
Member

In #135031, we gained support for just leaving away the body. Now that the bootstrap compiler got bumped, stop using the old style and remove support for it.

r? @oli-obk

There are a few more mentions of this attribute in RA code that I didn't touch; Cc @rust-lang/rust-analyzer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Feb 23, 2025
@rustbot

rustbot commented Feb 23, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the platform-builtins intrinsics. Make sure the
LLVM backend as well as portable-simd gets adapted for the changes.

cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @rust-lang/wg-const-eval

@Veykril

Veykril commented Feb 23, 2025

Copy link
Copy Markdown
Member

There are a few more mentions of this attribute in RA code that I didn't touch; Cc @rust-lang/rust-analyzer

We'll remove that eventually when dropping support for older toolchains 👍

@RalfJung RalfJung force-pushed the no-more-rustc_intrinsic_must_be_overridden branch from 4877a01 to b94b518 Compare February 23, 2025 16:40
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung RalfJung force-pushed the no-more-rustc_intrinsic_must_be_overridden branch from b94b518 to 7477051 Compare February 23, 2025 17:27
@oli-obk

oli-obk commented Feb 23, 2025

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7477051 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025
@jieyouxu jieyouxu mentioned this pull request Feb 23, 2025
Closed
antoyo
antoyo reviewed Feb 23, 2025
View reviewed changes
Comment thread compiler/rustc_codegen_gcc/tests/run/abort1.rs
pub fn abort() -> ! {
loop {}
}
pub fn abort() -> !;

@antoyo antoyo Feb 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it seems I forgot to remove and use the one from mini_core. I created an issue for this.

@jhpratt jhpratt mentioned this pull request Feb 24, 2025
Closed
@bors

bors commented Feb 24, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #137497) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2025
@RalfJung RalfJung force-pushed the no-more-rustc_intrinsic_must_be_overridden branch from 7477051 to 6eea027 Compare February 24, 2025 06:54
@RalfJung

RalfJung commented Feb 24, 2025

Copy link
Copy Markdown
Member Author

@bors r=oli-obk

@bors

bors commented Feb 24, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 6eea027 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2025
@RalfJung RalfJung mentioned this pull request Feb 24, 2025
Merged
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 24, 2025
Closed
@folkertdev folkertdev mentioned this pull request Feb 24, 2025
Merged
@compiler-errors

compiler-errors commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

@bors rollup

@compiler-errors compiler-errors mentioned this pull request Feb 25, 2025
Merged
@bors bors merged commit 8f729e9 into rust-lang:master Feb 25, 2025
@rustbot rustbot added this to the 1.87.0 milestone Feb 25, 2025
@RalfJung RalfJung deleted the no-more-rustc_intrinsic_must_be_overridden branch February 25, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antoyo antoyo antoyo left review comments

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.87.0

Development

Successfully merging this pull request may close these issues.

8 participants

@RalfJung @rustbot @Veykril @rust-log-analyzer @oli-obk @bors @compiler-errors @antoyo