Enable Miri to pass pointers through FFI#129684
Merged
Merged
Conversation
Collaborator
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri The Miri subtree was changed cc @rust-lang/miri |
Contributor
Author
|
Oh. Well that didn't work yet. |
RalfJung
reviewed
Aug 28, 2024
RalfJung
reviewed
Aug 28, 2024
RalfJung
reviewed
Aug 28, 2024
RalfJung
reviewed
Aug 29, 2024
| @@ -1 +1,2 @@ | |||
| printing from C | |||
| printing pointer dereference from C: 42 | |||
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
(I might quickly try to enhance+refactor the C pointer FFI tests in Miri now.) |
RalfJung
reviewed
Aug 29, 2024
RalfJung
reviewed
Aug 29, 2024
RalfJung
reviewed
Aug 30, 2024
RalfJung
reviewed
Aug 30, 2024
Strophox
force-pushed
the
miri-pass-pointer-to-ffi
branch
from
August 30, 2024 09:04
dcdb101 to
6e23a4d
Compare
RalfJung
reviewed
Aug 30, 2024
RalfJung
left a comment
Member
There was a problem hiding this comment.
Looks good overall, thanks! Just got some nits regarding the tests.
RalfJung
reviewed
Aug 30, 2024
Member
|
Please squash the commits, then we can land this. :-) |
Co-authored-by: Ralf Jung <post@ralfj.de>
Strophox
force-pushed
the
miri-pass-pointer-to-ffi
branch
from
August 30, 2024 14:12
730bd97 to
7fde02e
Compare
Member
|
Great, congrats on getting this finished! @bors r+ |
Collaborator
This was referenced Aug 31, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #126787, the purpose of this PR is to now enable Miri to execute native calls that make use of pointers.
Note that this PR does not yet implement any logic involved in updating Miri's "analysis" state (byte initialization, provenance) upon such a native call.
r? @RalfJung