Correctly Handle Unlinked Module Edge Cases - #22977
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
requested changes
Aug 1, 2026
A4-Tacks
requested changes
Aug 1, 2026
George-Ogden
force-pushed
the
linked-module-names
branch
from
August 2, 2026 08:16
2a9d5d2 to
7a3ed16
Compare
A4-Tacks
approved these changes
Aug 2, 2026
George-Ogden
force-pushed
the
linked-module-names
branch
from
August 2, 2026 14:46
24046d5 to
d3f5bd9
Compare
A4-Tacks
approved these changes
Aug 2, 2026
Escape keywords when used as module names Display modules with non-identifier names using #[path = "..."] syntax
George-Ogden
force-pushed
the
linked-module-names
branch
from
August 2, 2026 15:13
d3f5bd9 to
53e7206
Compare
Contributor
Author
|
Thanks for all your feedback. I've squashed it into one commit. Would it make sense for squash merging to be the default in the future? |
A4-Tacks
approved these changes
Aug 2, 2026
Member
I personally think normal merges are easy to track and can preserve the details of PR authors, which can also help resolve conflicts in large PR |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22976:
#[path = "..."]syntax