fix: replace_derive_with_manual_impl drops #[cfg] on Debug (and other traits) - #22859
Open
xunilrj wants to merge 5 commits into
Open
fix: replace_derive_with_manual_impl drops #[cfg] on Debug (and other traits)#22859xunilrj wants to merge 5 commits into
xunilrj wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem when struct/enum fields/variants have
#[cfg(...)]attributes. In theses casesreplace_derive_with_manual_implaccess the field/variant directly without the attribute. Example:One case were I was not able to fix is the case of
#[cfg(...)]inside tuple structs. Unfortunatelyrustcdoes not accept#[cfg(...)]when pattern matching:That would demand something like the below, which becomes very complex, very quickly. I think makes more sense to remove this limitation in
rustcdirectly. Later, I will see if am able to do this.The same problem happens for other traits:
Clone,Default,Hash,PartialEq,PartialOrd. If this PR is merged I can create the next ones, as they are very similar.Another case is
#[cfg_attr]which is very similar but it is much harder to deal with. Not sure if we want to support it or not.One problem I had was that I was not able to find an easy way to create statements with attributes in one go, something like
make::stmt_with_attrs(...). That made the code more complex than necessary as I first create blocks, and then splice statements with their attributes.