redox: clock_settime, pause - #5363
Conversation
rustbot
added
O-redox
O-unix
stable-nominated
e089b27 to
20f1ff8
Compare
|
Looks reasonable enough, any reason this is a draft? |
|
Hi again! And no - there isn't anything wrong with the PR itself, but I assume Jeremy still has to take a look so I set it as a draft until then. |
There was a problem hiding this comment.
Think this should be changed but LGTM. @jackpot51 if you'd like to review as well.
Also: if you happen to have any redox knowledge, it would be nice to get our CI job going. #5355 is an attempt but I think it could use some help.
| pub fn gettimeofday(tp: *mut crate::timeval, tz: *mut crate::timezone) -> c_int; | ||
| pub fn clock_getres(clk_id: crate::clockid_t, tp: *mut crate::timespec) -> c_int; | ||
| pub fn clock_gettime(clk_id: crate::clockid_t, tp: *mut crate::timespec) -> c_int; | ||
| pub fn clock_settime(clk_id: crate::clockid_t, tp: *mut crate::timespec) -> c_int; |
There was a problem hiding this comment.
This one looks const from the linked source
There was a problem hiding this comment.
Fixed. 😁 I've contributed to Redox but my CI and toolchain knowledge is paltry. However, I'll ask around because there are very smart people contributing to Redox who could likely fix it.
My current goal is to ensure libc, nix, and Rustix are up to date with respect to Redox so that downstream consumers don't have to feature gate Redox. Working CI for libc is definitely a step in the right direction for that goal.
|
Reminder, once the PR becomes ready for a review, use |
Related: bytecodealliance/rustix#1638 clock_settime: https://gitlab.redox-os.org/redox-os/relibc/-/blob/3628bf4677029f0a3186f7d859789a573c47a334/src/header/time/mod.rs#L301 pause: https://gitlab.redox-os.org/redox-os/relibc/-/blob/b3d55c929ed11f276310b32659d0171e063b8448/src/header/unistd/mod.rs#L851
20f1ff8 to
dd3e3bb
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot ready |
4 participants
Related: bytecodealliance/rustix#1638
Sources:
Description
I unmasked
clock_settimeandpauseon Redox as both have been supported for a while.Checklist
libc-test/semverhave been updated*LASTor*MAXhave the standarddoc comment
cargo test -p libc-test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated