refactor: deprecate RAND_MAX constant in FreeBSD#5119
Open
dybucc wants to merge 1 commit into
Open
Conversation
35d04d3 to
4346f10
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This constant does not seem to have had any changes since a binding was defined in all modules but the FreeBSD tree. This deprecation may or may not be worth it, as the only real change was between FreeBSD 12 and FreeBSD 13.
4346f10 to
ddee909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This constant does not seem to have had any changes since a binding was defined in all modules but
the FreeBSD tree.
This deprecation may or may not be worth it, as the only real change was between FreeBSD 12 and
FreeBSD 13.
This type of constant seems like the "delimitter" value mentioned in #3131, so that's why I thought
it could be marked for deprecation.
Sources
libcwhere the constant was added to specific FreeBSD releases as it changedbetween FreeBSD 12 and FreeBSD 13.
https://github.com/rust-lang/libc/blob/main/src/unix/bsd/freebsdlike/freebsd/freebsd15/mod.rs#L323
value
rand.https://en.cppreference.com/c/numeric/random/RAND_MAX
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI