Skip to content

Add simx00x driver#516

Open
skilvingr wants to merge 1 commit intorust-embedded:masterfrom
skilvingr:master
Open

Add simx00x driver#516
skilvingr wants to merge 1 commit intorust-embedded:masterfrom
skilvingr:master

Conversation

@skilvingr
Copy link
Copy Markdown

UART driver based upon embedded-io for the SIM800L module.

Copy link
Copy Markdown
Member

@BartMassey BartMassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks much.

Since you depend on heapless, you might want to use heapless::Dequeue instead of your own ring buffer, but maybe there's some constraint that makes that not work?

The crate name is a bit surprising, since this is specifically for the SIM800L it looks like?

All of this is fine, though.

@skilvingr
Copy link
Copy Markdown
Author

Since you depend on heapless, you might want to use heapless::Dequeue instead of your own ring buffer, but maybe there's some constraint that makes that not work?

No, it's just that I didn't know it existed at all. Thanks for the suggestion. I'll run some benchmarks and, if it makes sense, I'll update the crate.

The crate name is a bit surprising, since this is specifically for the SIM800L it looks like?

Well, it has been tested only with a SIM800L for the moment, but it seems that similar modules, like SIM800H and SIM900L, work with the same set of commands, hence the surprisingname.

Given this, should I change at least the description in the README or is it still fine?

@BartMassey
Copy link
Copy Markdown
Member

Things are fine. Thanks much for sharing this crate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants