Skip to content

Handle empty key derivation paths - #1013

Open
febyeji wants to merge 1 commit into
rust-bitcoin:masterfrom
febyeji:fix-plan-empty-derivation-path
Open

Handle empty key derivation paths#1013
febyeji wants to merge 1 commit into
rust-bitcoin:masterfrom
febyeji:fix-plan-empty-derivation-path

Conversation

@febyeji

@febyeji febyeji commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #996.

  • Prevent an underflow when the planner handles a raw key with no derivation path.
  • Add a regression test based on the issue reproduction, validated with OpenAI Codex and reviewed by the author.

- Prevent an underflow when the planner handles a raw key with no derivation path.
- Add a regression test based on the issue reproduction, validated with OpenAI Codex and reviewed by the author.

Assisted-by: OpenAI Codex GPT-5
@febyeji febyeji changed the title fix: handle empty key derivation paths Handle empty key derivation paths Aug 3, 2026

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de22d41; successfully ran local tests; thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Planner/assets helpers panic on raw no-origin keys with matching fingerprint and non-empty asset path

2 participants