size_of_val, min_align_of_val implementation#1092
Open
mariaKt wants to merge 10 commits into
Open
Conversation
40 new passing tests (this PR and PR #1091: static refs)
mariaKt
force-pushed
the
mk/intrinsics-impl
branch
from
cf7ad67 to
ddd1c22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
size_of_val,min_align_of_valfor sized types.I show the stuck state and passing state before and after each one's implementation, and remove the output files at the end (included only to help review).
We do not handle unsized types atm, left for future work (their dynamic size calculation is likely to change).
Finally, we update the skip lists for the LLVM and Haskell backend. Note that these newly passing tests reflect not just this PR, but also PR #1091.