Skip to content

Update Fitzgerald.gg - #15580

Merged
runelite-github-app[bot] merged 7 commits into
runelite:masterfrom
Fitzgerald-gg:fitzgerald-live
Aug 28, 2026
Merged

Update Fitzgerald.gg#15580
runelite-github-app[bot] merged 7 commits into
runelite:masterfrom
Fitzgerald-gg:fitzgerald-live

Conversation

@Fitzgerald-gg

@Fitzgerald-gg Fitzgerald-gg commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Adding local support and the inclusion of skill stat tracking.

@runelite-github-app

runelite-github-app Bot commented Aug 27, 2026

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented Aug 27, 2026

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Alexsuperfly

Copy link
Copy Markdown
Contributor
  • use of Desktop::browse is not allowed, use LinkBrowser::browse instead

@Alexsuperfly Alexsuperfly added the waiting for author waiting for the pr author to make changes or respond to questions label Aug 28, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Aug 28, 2026
@Fitzgerald-gg

Copy link
Copy Markdown
Contributor Author

Sorry. I've removed the direct java.awt.Desktop use. Since LinkBrowser.browse only accepts http/https schemes and this button opens a locally-generated .html file, I've routed it through LinkBrowser.open(path) instead — is that okay? It seems to be the RuneLite helper for local paths, and it launches the file in the default browser via the wrapped OS opener. The cloud variant of the same button already uses LinkBrowser.browse. Updated the plugin commit accordingly.

Let me know if I need to change my approach.

@Alexsuperfly

Copy link
Copy Markdown
Contributor

you cannot use LinkBrowser.open

@ldavid432

Copy link
Copy Markdown
Contributor

LinkBrowser.open is not allowed either. If you want you can have a button copy the URL to the clipboard, that is what I have seen most plugins do instead.

@Fitzgerald-gg

Copy link
Copy Markdown
Contributor Author

Thanks for the pointer - I have amended to that approach.

In local mode the button now copies the page link to the clipboard as you suggested, rather than opening anything directly; cloud mode still opens the profile URL via LinkBrowser.browse.

@runelite-github-app
runelite-github-app Bot merged commit 9679657 into runelite:master Aug 28, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants