Add Everykill - #15575
Open
Delkyy wants to merge 3 commits into
Open
Conversation
|
Includes changes by non-author New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Contributor
|
Because everykill is an organization you will need to add |
Contributor
Author
|
Done, thanks. added in d66c62a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kill counts for every monster in the game, not just the ~90 on the hiscores.
There are over 1,000 monsters in OSRS. The official hiscores rank about 90 of them, so nobody knows who's killed the most Rockslug, nothing counts them. This plugin counts them, locally, and grades every kill by how well it can be evidenced.
Why it isn't a duplicate: Collection Log Luck does log slots, Dry Rate Tracker does raid dryness, Bossing Info covers the bosses that already have hiscores. Those answer "how am I doing" from your own data. This answers "how am I doing compared to everyone else", which needs a shared denominator. Loot Lookup owns drop tables and Dink owns Discord webhooks — neither is rebuilt here, and milestones are handed to Dink via
PluginMessagerather than a second webhook implementation.Upload is opt-in and off by default. With it off the plugin is fully useful and makes no network calls. With it on, it sends kill records to everykill.com. Your RuneScape name is never sent unless you separately turn on name publishing, which is its own toggle and also defaults off. There's an in-plugin export and delete for anything already uploaded.
Notes for review:
build=standard, Java 11,@InjectOkHttp and Gson, all calls onenqueue()Thread.sleepBSD 2-Clause. 186 tests.