Skip to content

Add Gielinor Safari - #15510

Open
WoodyCode23 wants to merge 9 commits into
runelite:masterfrom
WoodyCode23:gielinor-safari
Open

Add Gielinor Safari#15510
WoodyCode23 wants to merge 9 commits into
runelite:masterfrom
WoodyCode23:gielinor-safari

Conversation

@WoodyCode23

Copy link
Copy Markdown
Contributor

This plugin is a way to collect and train NPCs that spawn randomly throughout the game to battle gyms and conquer cities. This can be played with friends via the party plugin for better rewards. The plugin learns new NPCS and all of their animations as they happen in game.

@runelite-github-app

runelite-github-app Bot commented Aug 26, 2026

Copy link
Copy Markdown

@WoodyCode23
WoodyCode23 marked this pull request as ready for review August 26, 2026 20:21
@runelite-github-app

runelite-github-app Bot commented Aug 26, 2026

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Alexsuperfly

Copy link
Copy Markdown
Contributor
  • use of KeyboardFocusManager is not allowed

@Alexsuperfly Alexsuperfly added the waiting for author waiting for the pr author to make changes or respond to questions label Aug 27, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Aug 27, 2026
@WoodyCode23

Copy link
Copy Markdown
Contributor Author

Fixed in 7b9a3d0, manifest bumped. Focus is now tracked with a listener on the spinner's own editor component instead.

@Alexsuperfly

Copy link
Copy Markdown
Contributor

the Build and Deploy section of your README is not even close to correct, remove it to not confuse users

@Alexsuperfly Alexsuperfly added the waiting for author waiting for the pr author to make changes or respond to questions label Aug 27, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Aug 27, 2026
@WoodyCode23

Copy link
Copy Markdown
Contributor Author

Removed in 4af2107, along with the internal design docs the README linked. Those described an earlier server-backed design that was dropped in favour of RuneLite's party system, so they were stale as well as confusing. Also went through the source and rewrote leftover development comments into explanations.

@Alexsuperfly

Copy link
Copy Markdown
Contributor

file io must be constrained to a subdirectory specific to your plugin within the RUNELITE_DIR

@Alexsuperfly Alexsuperfly added the waiting for author waiting for the pr author to make changes or respond to questions label Aug 27, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Aug 27, 2026
@WoodyCode23

Copy link
Copy Markdown
Contributor Author

Done in 526ef53, everything now lives under gielinor-safari/ in the RuneLite directory with the old files migrated across.

Also went through recent hub reviews and fixed two things preemptively in 2088159: the LICENSE is now the plugin-hub one with my attribution, and the wiki image lookup no longer trusts a file name out of an API response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants