Skip to content

Update DropTracker to v5.4.0#13405

Open
joelhalen wants to merge 6 commits into
runelite:masterfrom
joelhalen:master
Open

Update DropTracker to v5.4.0#13405
joelhalen wants to merge 6 commits into
runelite:masterfrom
joelhalen:master

Conversation

@joelhalen

@joelhalen joelhalen commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Adds a number of reliability enhancements and features:

  • Fixes raid split tracking logic
  • Reset data for various handlers on relog to prevent partial data issues
  • fix EDT blocking group config fetching
  • fix webhook url management to be more resilient
  • move image conversion off frame listener thread to prevent client stalls
  • replace boss-name switch method with a registry
  • implement unit tests for future development
  • support tracking deaths
  • support tracking achievement diaries
  • accurately determine if the player's plugin is out of date and notify them
  • enhancements to submission panel to provide better insights into the lifestyle of a submission

Much of these changes were assisted using Claude Fable 5, just for full transparency :)

@runelite-github-app

runelite-github-app Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

droptracker: 2a33535b9c677e4c13791f2a69e8066f0882396e..fc382967d23785b8b8b9728242bcd66027d5dfd5

@runelite-github-app

runelite-github-app Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

Internal use only: Reviewer details Maintainer details

joelhalen added 2 commits July 8, 2026 14:24
@joelhalen
Add support for Maggot King + Experience Tracking
98a966f 
re-implements periodic experience tracking for event purposes, and adds Maggot King drop functionality back.
@joelhalen
Update droptracker
6311514 
Storage backends (B2) occasionally return 5xx on presigned PUTs; a single failed attempt previously lost the entire clip and silently fell back to screenshot-only. The PUT now retries up to 3 times with backoff against the same presigned URL (re-presigning would consume daily video quota), skipping retries on 4xx. After exhausting attempts, the plugin reports the failure to /video/upload-failed so the server records the real reason instead of the ticket aging out as expired.

Intermediate JPEG quality drops 0.80 -> 0.65: the server re-encodes to H.264 at CRF 28, which discards ~97% of uploaded bytes, so the extra quality never reached the final video while doubling upload size and failure exposure.
@riktenx

riktenx commented Jul 11, 2026

Copy link
Copy Markdown
Member
  • use of thread sleep is not allowed; use a scheduled executor etc. instead
  • use of thread interrupt is not allowed

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jul 11, 2026
@riktenx

riktenx commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

also jfyi your code is not auto-reviewable due to use of sensitive lwjgl code. you are welcome to wait for manual review but there is nobody really doing that at the moment. if you would prefer to continue updating your plugin on a regular cadence you might want to remove lwjgl-based features for now

@joelhalen

joelhalen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

also jfyi your code is not auto-reviewable due to use of sensitive lwjgl code. you are welcome to wait for manual review but there is nobody really doing that at the moment. if you would prefer to continue updating your plugin on a regular cadence you might want to remove lwjgl-based features for now

Thanks for the heads up. I'll see if I can tackle this this weekend.

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jul 11, 2026
@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jul 11, 2026
@joelhalen
Replace blocking upload retry backoff with scheduled executor
cf3d5e7 
RuneLite disallows Thread.sleep and Thread.interrupt usage in plugins.
Both were used only in SubmissionManager.uploadVideoFrames, where a synchronous retry loop slept between video-upload attempts and caught InterruptedException with Thread.currentThread().interrupt().
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jul 11, 2026
@joelhalen

joelhalen commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

also jfyi your code is not auto-reviewable due to use of sensitive lwjgl code. you are welcome to wait for manual review but there is nobody really doing that at the moment. if you would prefer to continue updating your plugin on a regular cadence you might want to remove lwjgl-based features for now

After a bit of digging, there's no way around us using lwjgl code in order to provide our video cap functionality. Not that it will make any difference for auto-review, but none of the relevant lwjgl code has changed in a meaningful way since our last update was approved...

I'll just cross my fingers it doesn't take months, and be patient. Thanks!

@riktenx riktenx added the manual review PR can't be merged by the reviewbot, requires review by a plugin hub maintainer label Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

manual review PR can't be merged by the reviewbot, requires review by a plugin hub maintainer plugin change size-l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joelhalen @riktenx