Update 07flip to 8bb3e9f#12082
Open
UserD40 wants to merge 1 commit into
Open
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update 07flip plugin to commit 8bb3e9f.
What this changes (small follow-up to #12078)
Tightens the new
Investedrow on the Trades stats panel so it only counts gp tied up in live GE activity right now:BUYINGstate - unchangedSELLINGstate, pro-rated by the qty still waiting to fillThe previous build was summing the cost basis of every
OpenPositionfrom the FIFO calculator, which inflated the number with two things the user doesn't think of as "invested in the GE":On a heavy flipper's account the loose definition overstated Invested by 200-400M gp from inventory hoarding alone. The tightened definition matches the panel's "money tied up in the GE right now" reading.
Implementation notes for reviewers
MyTradesStatsPanel.update()gains aheldCostBasisInActiveSellsparameter. Older 5-arg / 6-arg overloads remain as compatibility shims that pass0L, so no behaviour change for any caller that hasn't been migratedProfitCalculator.openPositionsand usesremainingCostBasis / remainingQtyas per-unit cost, capped at the qty currently in the active sell. SOLD and CANCELLED_SELL states are deliberately excluded (items are gone or returned to bank)Verified on a real GE state: 8 active offers (4 buys totalling 191M, 4 sells with combined cost basis ~93M), Invested = 282.5M, which reconciles exactly with the listing prices and the FIFO cost basis from prior buys.