Dedup the scanner report for unpatched gems with more than one platform#440
Open
jrodriigues wants to merge 2 commits into
Open
Dedup the scanner report for unpatched gems with more than one platform#440jrodriigues wants to merge 2 commits into
jrodriigues wants to merge 2 commits into
Conversation
Member
|
I was waiting until another team member returns from vacation, but my thought is to |
Author
|
That makes sense, I will push something to cover that scenario. |
simi
reviewed
Jul 4, 2026
| activesupport (= 3.2.10) | ||
| arel (~> 3.0.2) | ||
| tzinfo (~> 0.3.29) | ||
| activerecord (3.2.10-aarch64-linux-gnu) |
Contributor
There was a problem hiding this comment.
Would it make sense to add actual real gem name here like nokogiri in two versions?
Author
There was a problem hiding this comment.
The reason I added it this way was to be as less intrusive as possible.
At first I did add nokogiri-1.19.3 with all the different platforms, but because the fixture database is pinned to an older commit it did not see those vulnerabilities.
At that point I decided to add a manual entry myself to avoid making too many modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438.
The scanner now deduplicates the unpatched gems on
[gem.name, gem.version, advisory.id].Notice that the spec can considered flaky. Without adding the
Gemfile.lockchange, it will pass as well.Let me know if you are happy with this approach or if you prefer something more robust.