Skip to content

fix: bypass burrito proxy writer when output is to a terminal - #166

Merged
bougyman merged 1 commit into
mainfrom
flush-zig-output
Aug 20, 2026
Merged

fix: bypass burrito proxy writer when output is to a terminal#166
bougyman merged 1 commit into
mainfrom
flush-zig-output

Conversation

@bougyman

Copy link
Copy Markdown
Member

The bug is Burrito 1.6’s new stdout relay from PR #225 (burrito-elixir/burrito#225). It made the wrapper a second owner of stdout. Issue #234
(burrito-elixir/burrito#234) and PR #235 (burrito-elixir/burrito#235) use the practical fix: when stdout is a TTY, let BEAM inherit it directly;
retain the relay only for pipes.

I ported that fix:

  • app/mix.exs:1 installs the release hook.

  • app/release/burrito_patches.exs:1 applies the upstream patch and fails closed if Burrito changes.

  • app/test/linear_cli/release/burrito_patches_test.exs:1 verifies it.

  • Linux Burrito binary compiled successfully.

  • A throttled pseudo-terminal emitted all 5,000 rows, including the final row, then exited 0.

  • Full suite: 312 tests passed.

  • Formatter check passed.

Need a follow-up on this when burrito gets the patch into mainstream

The bug is Burrito 1.6’s new stdout relay from PR #225 (burrito-elixir/burrito#225). It made the wrapper a second owner of stdout. Issue #234
  (burrito-elixir/burrito#234) and PR #235 (burrito-elixir/burrito#235) use the practical fix: when stdout is a TTY, let BEAM inherit it directly;
  retain the relay only for pipes.

I ported that fix:

- app/mix.exs:1 installs the release hook.
- app/release/burrito_patches.exs:1 applies the upstream patch and fails closed if Burrito changes.
- app/test/linear_cli/release/burrito_patches_test.exs:1 verifies it.

- Linux Burrito binary compiled successfully.
- A throttled pseudo-terminal emitted all 5,000 rows, including the final row, then exited 0.
- Full suite: 312 tests passed.
- Formatter check passed.

Need a follow-up on this when burrito gets the patch into mainstream
Copilot AI lite review requested due to automatic review settings August 20, 2026 18:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bougyman
bougyman merged commit 070a1d6 into main Aug 20, 2026
2 checks passed
@bougyman
bougyman deleted the flush-zig-output branch August 20, 2026 18:11
bougyman pushed a commit that referenced this pull request Aug 20, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.0.1](v2.0.0...v2.0.1)
(2026-08-20)


### Bug Fixes

* bypass burrito proxy writer when output is to a terminal
([#166](#166))
([070a1d6](070a1d6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants