Add bar/pie chart toggle and cap ongoing allocations at 100% - #96
Merged
Conversation
Scenario show page now lets users switch the ongoing-giving chart between the existing horizontal bar and a new CSS conic-gradient pie chart, via a small pill toggle built on the existing tabs Stimulus controller. Also adds validation so ongoing allocation percentages (including Greatest Community Need) can no longer sum to more than 100% for a scenario, mirroring the existing one-time/total-giving-amount check. The percentage sliders now clamp their max to the actual remaining headroom (falling back to the allocation's own current value so already-over-limit legacy data still renders correctly) instead of a hardcoded 100, and their CSS fill is rescaled to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conic-gradient, no new JS dependency), using the existingtabsStimulus controller.maxto actual remaining headroom instead of a hardcoded 100 (falling back to the allocation's own current value, so any already-over-limit legacy data still renders sanely), with the CSS fill rescaled to match.Test plan
bin/rails test— 263 runs, 0 failuresbin/rubocopon changed Ruby files — no offensesbundle exec herb linton changed views — no new offenses🤖 Generated with Claude Code