Reap all workspace port listeners on archive and server boot#2002
Merged
Conversation
The archive hook killed only the first listener on each workspace port with a quoted `kill "$pid"`, which passed lsof's newline-joined multi-PID output as a single argument and silently failed. Puma cluster workers (and `bin/vite dev`'s esbuild children) were left orphaned, staying bound to the port and colliding with the next workspace to recycle the block. Word-split the PID list, SIGTERM each, then SIGKILL survivors, and free the same ports on conductor-server boot so a ghost from a crashed session self-heals instead of failing to bind. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
July 17, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small POSIX-sh port-cleanup change in two conductor scripts, no app logic
What is the goal of this PR and why is this important?
kill "$pid", which passedlsof's newline-joined multi-PID output as a single argument and silently failed.bin/vite dev's esbuild children) were left orphaned — still bound to the port — and collided with the next workspace to recycle the block. This is the same leak we just fixed in festilite.How did you approach the change?
free_portsreaper to bothbin/conductor-archiveandbin/conductor-server: word-split the PID list, SIGTERM each, then SIGKILL survivors after a grace beat.conductor-servernow freesPORT/PORT+36on boot too, so a ghost from a crashed session self-heals instead of failing to bind.Anything else to add?
sh -nclean. No Ruby/app changes.