Skip to content

Consolidate CE + art supplies built-ins onto callout rows; drop legacy columns#1984

Closed
maebeale wants to merge 1 commit into
mainfrom
maebeale/consolidate-ce-art-supplies-callouts
Closed

Consolidate CE + art supplies built-ins onto callout rows; drop legacy columns#1984
maebeale wants to merge 1 commit into
mainfrom
maebeale/consolidate-ce-art-supplies-callouts

Conversation

@maebeale

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 5 Inspect 🔬 migrations that drop Event columns + removal of two standalone pages + wide callout-system changes

What is the goal of this PR and why is this important?

  • Every built-in callout page now renders its intro copy from the materialized callout row's "Callout page text" (CE, handouts, FAQ, scholarship previously accepted the text but silently dropped it).
  • Finishes migrating the CE and "art supplies" (formerly event_details) built-ins fully onto their callout rows, so their content is edited in one place like every other built-in.

How did you approach the change?

  • Drop the legacy event-level columns ce_hours_details / ce_hours_details_label and event_details / event_details_label (two reversible migrations, no backfill — the ticket system isn't in production use for these and dev data re-seeds).
  • Delete the two orphaned standalone pages events#ce_hours and events#details (nothing linked to them; superseded by the callout pages).
  • Make art_supplies a content callout so it renders on the generic callout page, and rename its magic_key event_detailsart_supplies (default title "Art supplies & what to bring").
  • Refactor the scholarship and FAQ pages onto the shared _callout_page layout (removes duplicated chrome).
  • Remove the dead editor branch + event_details_card plumbing.

Anything else to add?

…y columns

Every built-in callout page now renders its copy from the materialized callout
row's "Callout page text" (CE, handouts, FAQ, scholarship previously dropped it).
Move CE and art_supplies (formerly event_details) fully onto the row: drop the
event-level ce_hours_details/_label and event_details/_label columns, delete the
orphaned events#ce_hours and events#details pages, make art_supplies a content
callout rendered on the generic callout page, and rename its magic_key. Refactor
the scholarship/faq pages onto the shared callout-page layout. No data backfill.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 14, 2026 20:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@maebeale

Copy link
Copy Markdown
Collaborator Author

🤖 From Claude: Superseded by #1996, which salvaged the still-relevant structural cleanup (dropped legacy Event columns, deleted the orphaned events#ce_hours/#details pages, event_detailsart_supplies content callout, FAQ/scholarship onto the shared _callout_page) and re-applied it on current main. Rebasing this branch conflicts across ~17 files and would revert newer main work (the callout controller's drip-scheduling/resource_cards logic, and the magic_keybuiltin_key de-magic rename from #1977). No salvageable residual remains, so closing.

@maebeale maebeale closed this Jul 15, 2026
maebeale added a commit that referenced this pull request Jul 15, 2026
…1997)

Salvaged from the closed #1984 (superseded by #1996), ported to current
builtin_key vocabulary. #1996 landed the structural cleanup but left these
two behavioral assertions uncovered at their respective layers:

- Model: art_supplies is a *content* built-in (behavioral_builtin? == false),
  unlike a behavioral built-in like certificate.
- Request: the CE and scholarship pages render the intro copy from their
  materialized callout row's description (FAQ already covered; handouts has
  no description intro).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants