Hide the scholarship card on free-event registrations#1974
Merged
Conversation
A scholarship offsets a registration fee, so the card has nothing to do on a free event — but the registration form rendered it unconditionally, next to the CE card (which already hides itself when the event grants no CE hours). Add Event#scholarship_eligible? (true when the event has a cost), mirroring the existing #ce_eligible? predicate, and gate the scholarship card on it. The Organizations card now absorbs whatever columns the hidden scholarship/CE cards leave behind, so the row never has a gap. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jul 14, 2026
| # A scholarship offsets a registration fee, so it only applies to paid events — | ||
| # a free event has nothing to subsidize. Mirrors #ce_eligible? as a named | ||
| # "does this apply" predicate, derived from the cost rather than a stored flag. | ||
| def scholarship_eligible? |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Final definition: eligible when the event has a cost or offers a scholarship form (there's no scholarship_form_id column — the form links through event_forms by role). The view additionally keeps the card when this registration already has an award, so an award that predates the event going free/formless isn't hidden.
maebeale
marked this pull request as ready for review
July 14, 2026 14:20
Gate on the registration's own scholarships too, so a scholarship awarded before the event was made free stays visible instead of being hidden. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
An event can invite scholarship applications even when free, so key eligibility off a cost or an attached scholarship form. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR, suggested 👤 review level: 📖 Read — small, contained view/logic change gated by a new predicate
What is the goal of this PR and why is this important?
event.ce_eligible?); scholarship had no equivalent gate.How did you approach the change?
Event#scholarship_eligible?, mirroring the existing#ce_eligible?predicate: true when the event has a cost (a scholarship offsets a fee) or offers a scholarship form (it invites applications even when free).sm:col-span-1/2/3), so the row never has a gap:UI Testing Checklist
Anything else to add?
🤖 Generated with Claude Code