-
Notifications
You must be signed in to change notification settings - Fork 24
Add CE request/payment deadlines to events #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f7e57e9
Add CE request/payment deadlines to events and surface them
maebeale 6225157
Surface CE deadlines in confirmation and reminder emails
maebeale 73e9c15
Move CE deadlines into the CE settings box, as labeled fields
maebeale 8a704e9
Reword the callout colour-override hint in plainer terms
maebeale e3c7ae6
Polish the CE settings box: teal fill, white inputs, clickable label
maebeale 762e208
Fold "(optional)" into the CE deadline labels
maebeale b0867b4
Point CE seed copy to email or the Portal contact us form
maebeale abd769e
Surface CE deadlines on the public registration CE section
maebeale ed0c65a
Capture license type on the public CE registration form
maebeale c4d8867
Add license state + expiry to the public CE form; require CE interest
maebeale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <%# CE deadlines for a CE-eligible event, shown in the confirmation and reminder | ||
| emails so registrants are nudged before the request/payment cutoffs β gated on | ||
| the event offering CE, not on this registrant having requested it yet (the | ||
| confirmation fires before anyone opts in). Locals: event (decorated). The | ||
| deadlines are plain dates, so no time zone is applied. %> | ||
| <% if event.ce_eligible? && (event.ce_hours_request_deadline || event.ce_payment_due_deadline) %> | ||
| <div style="text-align: left; background-color: #f0fdfa; border: 1px solid #99f6e4; border-radius: 6px; padding: 16px; margin: 16px 0;"> | ||
| <p style="font-size: 14px; font-weight: 600; color: #115e59; margin: 0 0 8px;"> | ||
| <%= event.ce_hours_details_label %> | ||
| </p> | ||
| <% if event.ce_hours_request_deadline %> | ||
| <p style="font-size: 14px; color: #374151; margin: 0 0 4px;"> | ||
| Request CE credit by <strong><%= event.ce_hours_request_deadline.strftime("%B %-d, %Y") %></strong> | ||
| </p> | ||
| <% end %> | ||
| <% if event.ce_payment_due_deadline %> | ||
| <p style="font-size: 14px; color: #374151; margin: 0;"> | ||
| CE payment due by <strong><%= event.ce_payment_due_deadline.strftime("%B %-d, %Y") %></strong> | ||
| </p> | ||
| <% end %> | ||
| </div> | ||
| <% end %> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <% if event.ce_eligible? && (event.ce_hours_request_deadline || event.ce_payment_due_deadline) %> | ||
| <%= event.ce_hours_details_label %> | ||
| <% if event.ce_hours_request_deadline %>Request CE credit by <%= event.ce_hours_request_deadline.strftime("%B %-d, %Y") %> | ||
| <% end %><% if event.ce_payment_due_deadline %>CE payment due by <%= event.ce_payment_due_deadline.strftime("%B %-d, %Y") %> | ||
| <% end %><% end %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <%# The CE settings an admin edits once continuing education is enabled: hours | ||
| offered, total cost, and the two optional deadlines. Rendered inside each | ||
| "Enable continuing education" box (single-form and multi-form variants). | ||
| Each field is labelled above its own white input so they read as distinct | ||
| fields; the date inputs match the event start/end date style. locals: f | ||
| (event form builder). %> | ||
| <div class="grid grid-cols-2 gap-x-4 gap-y-3 sm:grid-cols-4"> | ||
| <div> | ||
| <%= f.label :ce_hours_offered, "CE hours offered", class: "block text-xs font-medium text-gray-600 mb-1" %> | ||
| <%= f.number_field :ce_hours_offered, min: 0, step: 0.25, | ||
| class: "w-full rounded border-gray-300 shadow-sm px-3 py-2 bg-white tabular-nums focus:ring-blue-500 focus:border-blue-500" %> | ||
| </div> | ||
| <div> | ||
| <%= f.label :ce_hours_cost, "Total CE cost", class: "block text-xs font-medium text-gray-600 mb-1" %> | ||
| <div class="relative"> | ||
| <span class="absolute left-3 top-1/2 -translate-y-1/2 text-gray-500">$</span> | ||
| <%= f.number_field :ce_hours_cost, min: 0, step: 1, | ||
| class: "w-full rounded border-gray-300 shadow-sm pl-7 pr-3 py-2 bg-white tabular-nums focus:ring-blue-500 focus:border-blue-500" %> | ||
| </div> | ||
| </div> | ||
| <div> | ||
| <%= f.label :ce_hours_request_deadline, class: "block text-xs font-medium text-gray-600 mb-1" do %> | ||
| Request CE credit by <span class="font-normal text-gray-400">(optional)</span> | ||
| <% end %> | ||
| <%= f.text_field :ce_hours_request_deadline, type: "date", | ||
| class: "w-full rounded border-gray-300 shadow-sm px-3 py-2 bg-white focus:ring-blue-500 focus:border-blue-500" %> | ||
| </div> | ||
| <div> | ||
| <%= f.label :ce_payment_due_deadline, class: "block text-xs font-medium text-gray-600 mb-1" do %> | ||
| Payment due by <span class="font-normal text-gray-400">(optional)</span> | ||
| <% end %> | ||
| <%= f.text_field :ce_payment_due_deadline, type: "date", | ||
| class: "w-full rounded border-gray-300 shadow-sm px-3 py-2 bg-white focus:ring-blue-500 focus:border-blue-500" %> | ||
| </div> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π€ From Claude: Gated on
event.ce_eligible?, notregistration.ce_registered?β the confirmation email fires at registration time, before anyone opts into CE, so registrant-level gating would hide the deadline from exactly the people it should nudge. Event-level shows it to everyone at a CE-eligible event.