Extend Node#set with additional input types#295
Merged
Conversation
duncan-bayne
force-pushed
the
extend-set
branch
from
1ccb728 to
2c48686
Compare
duncan-bayne
commented
May 4, 2026
| expect(input.text).to eq("replacement text") | ||
| end | ||
|
|
||
| it "sets a date field" do |
Contributor
Author
There was a problem hiding this comment.
I decided to leave these in as there wasn't test coverage, even though support for setting most of these has already been added upstream.
Contributor
Author
|
Apologies it's taken so long but I've come back and cleaned up this PR; it's now green on tests and linting, and should be ready for review. |
Member
|
Looks reasonable. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new targets to
Page#set:... and adds some tests for existing targets.