Repository navigation
ssl: add SSLSocket#min_version= and #max_version= - #1132
Merged
Merged
Conversation
rhenium
reviewed
Oct 27, 2026
| return arg; | ||
| } | ||
|
|
||
| /* |
Member
There was a problem hiding this comment.
Thanks for working on this! The changes look mostly good to me.
As for style, I'd prefer these to be placed next to the SSLContext counterparts, even though that means the declaration order no longer match the order of rb_define_method() calls. I think it's more useful to keep the internal helper (or #ifdef's, for accessors that need them) localized.
Member
Author
There was a problem hiding this comment.
It makes sense. I've moved these definitions:
ossl_sslctx_set_min_versionossl_ssl_set_min_versionossl_sslctx_set_max_versionossl_ssl_set_max_version
Allow setting the supported protocol version range per connection. They are the SSLSocket counterparts of SSLContext#min_version= and #max_version=. This is a step toward configuring the SSL object directly from callbacks instead of switching the SSLContext. See also: ruby#1125 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kou
force-pushed
the
ssl-socket-minmax-version
branch
from
October 28, 2026 02:48
58bb0cc to
89a15cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow setting the supported protocol version range per connection. They are the SSLSocket counterparts of SSLContext#min_version= and #max_version=.
This is a step toward configuring the SSL object directly from callbacks instead of switching the SSLContext.
See also: #1125