🥅 Guard against tagged responses sent too soon#690
Open
nevans wants to merge 5 commits into
Open
Conversation
nevans
force-pushed
the
guard-other-premature-tagged-responses
branch
from
aefbd2f to
ed6e9cf
Compare
Combine the two error raising conditionals into a single if/elsif stmt.
Combine `#disconnect` and raise for both error handlers.
`#get_tagged_response` is called twice, from `#send_command` and `#idle`, and both callers already handle `InvalidResponseError` by disconnecting.
The client thread may decide to drop the connection when it sees these exceptions: * `InvalidResponseError` in `#send_command` * `InvalidResponseError` in `#idle` (TODO: refactor to `#send_command`) * _Any_ `Exception` after `#starttls` returns tagged `OK` This saves those to an instance variable, which may be used as a cause for other raised errors.
The premature tagged response guard that was added for #644 only checked for premature `OK`, not for premature `BAD` or `NO`. When those are detected prior to the tag being sent, this treats those cases as the same sort of error. Note that this explicitly raises a "closed stream" IOError when disconnected. This is the error that would be raised anyway, if `send_command` were allowed to write to the connection. But, if we can test that the socket is already closed, we can raise the error directly. There's no need to attempt to format and send data.
nevans
force-pushed
the
guard-other-premature-tagged-responses
branch
from
ed6e9cf to
0841b08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The premature tagged response guard that was added for #644 only checked for premature
OK, not for prematureBADorNO. When those are detected prior to the tag being sent, this treats those cases as the same sort of error.Note that this explicitly raises a "closed stream" IOError when disconnected. This is the error that would be raised anyway, if
send_commandwere allowed to write to the connection. But, if we can test that the socket is already closed, we can raise the error directly. There's no need to attempt to format and send data. A future version will probably change this to raise a different error (subclass ofNet::IMAP::Error) instead.