parser.c: Extract json_match_keyword#996
Merged
Merged
Conversation
Extracted from: ruby#994 Modern compilers shouldn't have problem computing `strlen` at compile time and generating the same code.
eregon
reviewed
Jun 5, 2026
Comment on lines
+1453
to
+1456
| static inline bool json_match_keyword(JSON_ParserState *state, const char *keyword, size_t offset) | ||
| { | ||
| // It is assumed that since `keyword` is always a literal, the compiler is able to constantize this | ||
| // `strlen` and several other computations in that routine, such as eliminating the `if (resumable)` branch. |
Member
There was a problem hiding this comment.
An ALWAYS_INLINE (I think available from CRuby headers) would help guarantee that, vs depending on the compiler inlining heuristics.
(inline doesn't mean to inline but just tolerate multiple definitions of it)
Member
Author
There was a problem hiding this comment.
yeah we have a shim for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from: #994 (trying the make it smaller so the perf regression is easier to spot)
Modern compilers shouldn't have problem computing
strlenat compile time and generating the same code.