[parser.c] simplify json_value_completed transition#995
Merged
Conversation
Member
|
Nah, I like it. But you'll have to rebase a bit. |
… transition from a JSON_PHASE_VALUE to the next phase.
samyron
force-pushed
the
sm/json_value_completed
branch
from
3391c3e to
2c97de5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the transition of of the next phase of the parser in
json_value_completed. Theenum json_frame_typeandenum json_frame_phaseare now equal when theframe->typeisJSON_FRAME_ROOT,JSON_FRAME_ARRAYorJSON_FRAME_OBJECTso the next phase equal to the currentframe->type.Looking at the disassembly this saves 39 instructions.
Admittedly this may be one notch too far on the cleverness scale and an actual lookup table would be easier to reason about.