Correct the 4.0.0 release notes and refresh the version benchmark - #2912
Merged
Merged
Conversation
Auditing the 4.0.0 CHANGELOG against every commit since v3.3.5 turned up three defects. #2824 and #2834 were both listed under 4.0.0, and #2834 was listed a second time under 3.3.5. The three entries describe one net change: #2824 fixed cascaded routes leaking route_info and path captures, #2829's squash silently replayed a stale router.rb over it, and #2834 restored it. The fix shipped in 3.3.5, so 4.0.0 keeps only #2829, whose "hand over to every remaining route" fix is genuinely new here. #2870 had no entry at all. It is the last of the #2864-#2867 params-DSL stack and the only merged lib-affecting PR in the range without one. The `http_digest` removal note sat under "Upgrading to >= 3.3", but #2849 is not in v3.3.5 and the section's own text says the method now raises NoMethodError -- which is only true from 4.0.0. Moved into the 4.0.0 block, next to the auth/http_basic positional-Hash entry. While there, closed a ```ruby fence opened at the ValidationErrors keyword-rename entry and never terminated, which was swallowing the heading and prose of the section that follows it. The version benchmark now benches the latest patch of each major/minor (3.0.1, 3.1.1, 3.2.1) rather than the .0 releases, with RESULTS.md regenerated on Ruby 4.0.6; README.md and app.rb follow the new list. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
ericproulx
force-pushed
the
chore/4-0-0-release-docs
branch
from
September 7, 2026 15:20
535a0d2 to
c8ec0b0
Compare
Danger ReportNo issues found. |
ericproulx
changed the title
ericproulx
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release audit of the 4.0.0
CHANGELOGagainst every commit sincev3.3.5, plus the benchmark refresh.Duplicate cascade-route entries. #2824 and #2834 were both listed under 4.0.0, and #2834 again under 3.3.5. All three describe one net change: #2824 fixed cascaded routes leaking
route_infoand path captures, #2829's squash silently replayed a stalerouter.rbover it, and #2834 restored it. That fix shipped in 3.3.5, so 4.0.0 now keeps only #2829 — its "hand over to every remaining route" fix is genuinely new here.Missing entry for #2870. Last of the #2864–#2867 params-DSL stack, and the only merged lib-affecting PR in the range with no entry. Added after #2867 in Features.
http_digestfiled under the wrong release. The removal note sat underUpgrading to >= 3.3, but #2849 is not inv3.3.5and the section's own text says the method now raisesNoMethodError— true only from 4.0.0.git blameputs the block at 9b5f638 "Remove http_digest (#2849)". Moved into the 4.0.0 block beside theauth/http_basicpositional-Hash entry.Unterminated code fence. A
```rubyopened at theValidationErrorskeyword-rename entry was never closed, swallowing the#### Grape::Exceptions::ValidationErrors no longer mixes in Enumerableheading and its prose into the code block. Closed it; every### Upgrading tosection now has an even fence count.Version benchmark. Benches the latest patch of each major/minor (3.0.1, 3.1.1, 3.2.1) instead of the
.0releases.RESULTS.mdregenerated on Ruby 4.0.6;README.mdandapp.rbfollow the new list, including thevs 3.0.0→vs 3.0.1column references.Test plan
danger-changelog'sChangelogFile#parsereports no bad lines and no global failures.v3.3.5now has aCHANGELOGentry; the remainder are 3.3.x-released fixes, the Land #2775–#2779 on master (stacked-merge recovery) #2780/Document the removal of the vestigial Endpoint Options format member #2781/Internalize all InheritableSetting state behind semantic accessors (integration of #2797–#2808) #2809 integration commits, and spec/benchmark-only PRs.UPGRADING.mdline count and per-section fence parity verified across all 36 sections.Docs and benchmark only — no
libchanges.🤖 Generated with Claude Code