Make --workers=1 single-threaded#680
Merged
Merged
Conversation
lydell
commented
Jul 21, 2026
Comment on lines
+75
to
+76
| // Simply remove the first occurrence of `console.warn`. This leaves the message string in parentheses behind, but that’s fine. | ||
| .replace('console.warn', '') |
Collaborator
Author
There was a problem hiding this comment.
This replaces the previous approach of re-assigning console.warn. This is simpler, and avoids messing with the global console.warn in the main thread.
lydell
commented
Jul 21, 2026
| having a port with the same name, which is a compile error. | ||
| -} | ||
| port elmTestPort__send : String -> Cmd msg | ||
| port elmTestPort__send : Decode.Value -> Cmd msg |
Collaborator
Author
There was a problem hiding this comment.
We now turn this into a JSON string in JS instead – and not at all in single-threaded mode.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is slightly faster, and being able to run everything in the same process makes debugging easier.
View the diff without whitespace changes since a lot of code became indented.