chore(scaffold): run init via @rtcamp/wp-tooling/init#721
Draft
aryanjasala wants to merge 1 commit into
Draft
Conversation
Resolve the init engine from the @rtcamp/wp-tooling npm dependency instead of probing vendor/rtcamp/wp-framework. Drops the Composer vendor path and the fs existence check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Switches
npm run initto the relocated init engine:require('@rtcamp/wp-tooling/init')instead of probingvendor/rtcamp/wp-framework/bin/scaffold.js. The engine is now an npm dependency, not a Composer vendor path.Changes
bin/init.js— require the engine from@rtcamp/wp-tooling/init; drop the vendor existence check and the now-unusedfsrequire.Blocked on
rtCamp/wp-tooling#32 (the
./initexport) being published + bumping the@rtcamp/wp-toolingversion pin here. Until thennpm run initresolves the engine only via a local link/pack. Draft until published.