Change path substitution var insertion#999
Open
matsl wants to merge 1 commit into
Open
Conversation
Only insert variable if it matches the first pos in the path. * hpath.el (hpath:substitute-var): Try the substitution on the absolute path. (hpath:substitute-var-name): Anchor regexp substitution on first pos. * test/hpath-tests.el (hpath:substitute-var-test): (hpath:substitute-var-name-test): Unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change path substitution var insertion.
Only insert variable if it matches the first pos in the path.
hpath.el (hpath:substitute-var): Try the substitution on the
absolute path.
(hpath:substitute-var-name): Anchor regexp substitution on first pos.
test/hpath-tests.el (hpath:substitute-var-test):
(hpath:substitute-var-name-test): Unit tests.
Why
When linking to a line in a file in the hyperb:dir where a relative
link would be created the var was substituted in the path but kept as
a relative path. Like this:
"..${hyperb:dir}/README.md:L14"Since it is a path with a variable it should be absolute.