Skip to content

Update test to check error message #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matsl merged 1 commit into from
Jun 29, 2026
Merged

Update test to check error message #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2026-06-29 Mats Lidell <matsl@gnu.org>

* test/hui-tests.el (hui--hbut-act--links): Check error messages
matches elink and glink. Remove old comments.

2026-06-28 Bob Weiner <rsw@gnu.org>

* hywiki.el (hywiki-include-special-modes): Add HyWiki support in csv,
Expand Down
21 changes: 9 additions & 12 deletions test/hui-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; Author: Mats Lidell <matsl@gnu.org>
;;
;; Orig-Date: 30-Jan-21 at 12:00:00
;; Last-Mod: 28-Jun-26 at 14:11:17 by Bob Weiner
;; Last-Mod: 29-Jun-26 at 14:23:29 by Mats Lidell
;;
;; SPDX-License-Identifier: GPL-3.0-or-later
;;
Expand Down Expand Up @@ -35,9 +35,6 @@

(ert-deftest hui--hbut-act--links ()
"Verify `hui:hbut-act' finds the ilink but not elink and glink."
;; What should happen for elink and glink is not clear to me so I'm
;; keeping the current behavior below that succeeds even for those
;; cases.
(with-temp-buffer
(set-window-buffer (selected-window) (current-buffer))
(insert "\
Expand All @@ -49,27 +46,27 @@
(action-key)
(should (string-match-p "123\n" cap)))

;; This should lead to possibly "No action defined for this
;; context; try another location" or something similar.
(erase-buffer)
(insert "\
<elink: Command >
<[Command]> <identity 456)>
")
(goto-char 4)
(ert-with-message-capture cap
(should-error (action-key)))
(let ((err (should-error (action-key) :type 'error)))
(should
(string-match-p (rx "No button " punct "Command" punct " in")
(cadr err))))

;; This should lead to possibly "No action defined for this
;; context; try another location" or something similar.
(erase-buffer)
(insert "\
<glink: Command >
<[Command]> <identity 789)>
")
(goto-char 4)
(ert-with-message-capture cap
(should-error (action-key)))))
(let ((err (should-error (action-key) :type 'error)))
(should
(string-match-p "No global button found for label: Command"
(cadr err))))))

(ert-deftest hui-gbut-edit-link-to-file-button ()
"A global button with action type link-to-file shall be possible to edit."
Expand Down