Conversation
Use in `hywiki-tests--edit'.
Also highlight wikiwords only when the wikiword hash table is non-empty, to fix bug #81594. hywiki-tests--bug-81594-file, hywiki-tests--bug-81594-buffer): Add tests for this.
Also fix many hywiki and hywiki-test issues.
hywiki-tests--preserve-hywiki-mode - Improve for fewer test failures and use
more broadly
hywiki-file-suffix - Rename to 'hywiki-file-extension' to avoid terminology
clash with #suffix in references.
hywiki-cache-save - Change 'save-buffer' to 'hypb:save-buffer-silently'.
Replace 'save-window-excursion' with 'save-excursion' to eliminate any display
change.
hywiki-create-referent, hywiki-add-page - Fix to add 'wikiword' suffix to
returned referent. This fixes referents in `hywiki-display-referent' to
always include the wikiword suffix.
hui:menu-help, hui:menu-choose - Add and use ? in minibuffer menus to display
a buffer with help for each current menu item.
man/hyperbole.texi (Invocation): Add doc for {?} minibuffer menu help key.
hkey-help-show - Add ? in addition to q as quit and restore window config in
the help buffer, for consistency with Hyperbole minibuffer menus. Fix
failure to match to visible window because 'memq t' was trying to match to t
when 'string-match-p' was returning the position of the match. Fix by
eliminating 'memq t' and using 'seq-filter' instead.
hkey-help-hide - Remove saved wconfig after it is restored.
hui:menu-last-help-string - Add and use in 'hui:menu-help' and
'(hui:menu-display-help' to determine whether to toggle display of help window
or not.
hui:menu-choose - Add menu symbol as required first arg and make 2nd arg,
'menu-alist, optional. 'menu' may be null if 'menu-alist' is given.
hui:menu-display-help, hui:menu-get-help-string - Add.
hui:menu-help - Call 'fit-window-to-buffer' for help buffer rather than trying
to enlarge or shrink relatively.
hywiki-tests--preserve-hywiki-mode - Don't run (hywiki-mode) when already
set to the newly specified mode; this prevents a cascade of wikiword
highlighting across all buffers when not necessary. Also do this only after
temp buffers and files are killed, not before.
hywiki-tests--save-referent-info-node-use-menu - Skip until issues with Info kbd-cmd calls are resolved. hywiki-tests--create-referent - Fix to call 'hywiki-get-referent' and adjust error msg match.
hywiki-tests--nonexistent-wikiword-with-section-should-create-wikiword - Add condition-case to handle error thrown when #section is not found.
hywiki-add-page - Clarify input and output formats. hy-delete-file-and-buffer - Add WARNING if 'file' does not exist, so this is logged as a possible issue.
Also, leave `page-name' unchanged and save singular version of it to `page-name-singular'. hywiki-tests--verify-preserve-hywiki-mode): Rewrite to not make nested use of the prdserve macro, as that fails and is unnecessary for the testing purpose. hywiki-tests--action-key-on-hywikiword-displays-page: Change (redisplay t) to (sit-for 0.01) which will also call 'redisplay'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hsys-denote.el - Remove left over comments on unused dn: prefix
hy-test-helpers:with-time - Add to time any part of a function
hywiki-get-referent-hasht - Fix 'hywiki--any-wikiword-regexp-list'
minibuffer menus - Add ? key to show/hide help for each menu
hywiki-tests--preserve-hywiki-mode - Make default-dir = hywiki-dir
hywiki-create-referent - Simplify let and improve error msg
hywiki-create-referent - Ensure 'default-directory' is set at end
hywiki-get-referent -: Add `absolute-path-flag' to return full path
hywiki-add-page - Add optional 'debug-flag' arg for when needed