fix: upgrade rstest examples and remove module type warnings#417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rstest/core@0.9.6and align related browser packages to0.9.6"type": "module"to the example packages whoserstest.config.tsfiles were being reparsed as ESM by Nodepnpm-lock.yamlfor the version updatesWhy
CI=true pnpm test:rstestwas emittingMODULE_TYPELESS_PACKAGE_JSONwarnings in examples that loadrstest.config.tsas ESM without declaring a package module type. That warning adds noise in CI and indicates an avoidable reparsing path in Node.Impact
The Rstest examples now run on the newer
0.9.6packages, and the affected examples declare ESM explicitly so their test config files load without the Node warning.Validation
CI=true pnpm test:rstest