Skip to content

perf: reduce Rstack CLI startup time#6

Merged
chenjiahan merged 2 commits into
mainfrom
chenjiahan/perf-rs-lint-startup
Jul 10, 2026
Merged

perf: reduce Rstack CLI startup time#6
chenjiahan merged 2 commits into
mainfrom
chenjiahan/perf-rs-lint-startup

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR imports the CLI logger directly from rslog so rs lint no longer eagerly loads @rsbuild/core and @rspack/core. It adds rslog to the workspace catalog as a development dependency, allowing Rslib to bundle it into the CLI output.

Performance

Measured with Hyperfine (--warmup 5 --runs 40) and node --run lint -- --help to isolate CLI startup:

Run order @rsbuild/core rslog Reduction
Existing → new 90.9 ± 7.4 ms 75.9 ± 6.6 ms 15.0 ms (16.5%)
New → existing 87.9 ± 4.6 ms 75.5 ± 5.4 ms 12.4 ms (14.1%)

Full lint runs remain dominated by file scanning and type checking, whose variance is larger than this fixed startup gain.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@chenjiahan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eb8cf9f1-f766-4fbd-be6f-4945e23952b4

📥 Commits

Reviewing files that changed from the base of the PR and between b54b768 and a4ee259.

📒 Files selected for processing (1)
  • scripts/dictionary.txt
📝 Walkthrough

Walkthrough

Added rslog to the workspace dependency catalog and the rstack package’s development dependencies. Updated the CLI logger import to use rslog instead of @rsbuild/core. The CLI execution and error-handling logic remain unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: reducing Rstack CLI startup time.
Description check ✅ Passed The description accurately explains the logger import change and its performance motivation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/perf-rs-lint-startup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan chenjiahan merged commit 1102e7b into main Jul 10, 2026
4 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/perf-rs-lint-startup branch July 10, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant